Repository navigation
Remove stale service.ready file - #1799
Open
MariemBaccari wants to merge 1 commit into
Open
MariemBaccari wants to merge 1 commit into
MariemBaccari wants to merge 1 commit into
Conversation
mickmis
requested changes
Oct 19, 2026
Contributor
There was a problem hiding this comment.
IMO we should go the other way around:
- remove the file being written
- add curl to packages being installed in dockerfile
- change healthcheck to query locally HTTP server at
/healthyand expect 200
This is more standard and more resilient. I'm actually surprised we do it that way even though we have the /healthy endpoint implemented. Right now if the process hangs in the container, it would still report healthy because it finds the file...
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes any pre-existing
service.readyfile to avoid the container showing up as healthy when it's still starting as described in the last paragraph in #1793.