Repository navigation
[uss_qualifier/scenarios/dss] Check that OIR requests rejected for missing OVNs leave subscriptions unchanged - #1831
MariemBaccari wants to merge 1 commit into
Conversation
c80c459 to
ce7c563
Compare
ce7c563 to
d272c5e
Compare
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
There was a problem hiding this comment.
Looks good to me with one small change and one possible (but not required) change.
|
|
||
| **[astm.f3548.v21.DSS0005,5](../../../../../../requirements/astm/f3548/v21.md)** requires the implementation of the DSS endpoint to allow callers to retrieve the subscriptions they created. | ||
|
|
||
| ## 🛑 Rejected request did not create or modify subscriptions check |
There was a problem hiding this comment.
If this check fails, it seems like the test scenario can still continue since that's what it did before. And, continuing test execution after check failure is the preferred outcome unless it would be very difficult to do so because knowing all the problems in one run is far better than each run revealing only the first-encountered problem.
| ## 🛑 Rejected request did not create or modify subscriptions check | |
| ## ⚠️ Rejected request did not create or modify subscriptions check |
|
|
||
| The subscriptions owned by the client within the planning area are queried before and after the rejected request, and compared. | ||
|
|
||
| ## 🛑 Successful subscription search query check |
There was a problem hiding this comment.
I don't think this needs to change since this fragment is only being run at the end of a scenario and it's a little harder to skip the check below if this one fails, but it seems like failing this check could allow the test scenario to continue (and therefore be changed to
This branch has not been deployed
2 participants
interuss/dss#1792 reported that, since interuss/dss#1690, a DSS rejecting an oir PUT with a 409 (missing OVNs) persists subscription changes. A conflicting creation with new_subscription leaves behind a new implicit subscription, and a conflicting mutation that specifies an existing implicit subscription changes it. This PR extends OIRKeyValidation to check that rejected requests have no side effect on subscriptions.