Skip to content

[benchmarker][scd] Keep a user going when an op intent delete fails #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barroco merged 1 commit into from
Oct 20, 2026
Merged

[benchmarker][scd] Keep a user going when an op intent delete fails #1832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions monitoring/benchmarker/engine/users/flight_planner/scd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,14 +531,19 @@ async def delete_op_intent_ref(

if op_intent_ref:
# TODO: delete op intent ref asynchronously
_, _, query = await self.user.run_sync_client_call(
dss_instance.delete_op_intent,
id=op_intent_id,
ovn=op_intent_ref.ovn,
)
try:
_, _, query = await self.user.run_sync_client_call(
dss_instance.delete_op_intent,
id=op_intent_id,
ovn=op_intent_ref.ovn,
)
queries = [query]
except QueryError as e:
queries = e.queries

success = query.status_code == 200
self.user.record_query(query, success)
success = bool(queries) and queries[0].status_code == 200
for query in queries:
self.user.record_query(query, success)
flight.completed_actions.append(
CompletedFlightAction(
type=FlightActionType.DeleteOpIntent,
Expand Down
Loading