[efi] Place debug directory within .rodata section - #1852
Merged
Merged
Conversation
Some strict PE parsers will refuse a debug directory that lies within the file headers (rather than within a defined section), and will fail to load the binary. Place the debug directory at the start of the .rodata section for iPXE, and at the start of the .data section for wimboot. The debug directory irritatingly includes an RVA and a file offset, neither of which can be calculated by the linker. Update these fields at the time of running elf2efi, after having calculated the file offsets for each section. Debugged-by: Kansu Dincer <kdincer@microsoft.com> Debugged-by: Christian Nilsson <nikize@gmail.com> Signed-off-by: Michael Brown <mcb30@ipxe.org>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some strict PE parsers will refuse a debug directory that lies within the file headers (rather than within a defined section), and will fail to load the binary.
Place the debug directory at the start of the .rodata section for iPXE, and at the start of the .data section for wimboot.
The debug directory irritatingly includes an RVA and a file offset, neither of which can be calculated by the linker. Update these fields at the time of running elf2efi, after having calculated the file offsets for each section.
Debugged-by: Kansu Dincer kdincer@microsoft.com
Debugged-by: Christian Nilsson nikize@gmail.com
Fixes: #1847