Skip to content

Ensure all sub-packages are installed by pip - #1668

Merged
david-tingdahl-nvidia merged 3 commits into
mainfrom
dtingdahl/ci/require-init-py-in-packages
Nov 18, 2026
Merged

david-tingdahl-nvidia merged 3 commits into
mainfrom
dtingdahl/ci/require-init-py-in-packages

Conversation

@david-tingdahl-nvidia

@david-tingdahl-nvidia david-tingdahl-nvidia commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Ensure all sub-packages are installed by pip

Why this change?

Setuptools skips any directory without an __init__.py and they are ignored by pip install. Editable mode pip install -e still work, because Python imports straight from the mounted source tree.

What changes?

  • Add an __init__.py to missing directories
  • Add isaaclab_arena/tests/test_package_layout.py. It reads the include globs from pyproject.toml and fails for any directory under them that has .py files but no __init__.py.

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR affects which Arena modules are available from non-editable wheel installs.

The PR appears safe to merge, with a non-blocking gap in the packaging check.

Findings

  1. P2 Parents escape the package check ▶

Summary

Adds three package initializers and two tests that check the source tree for missing initializers and stale exceptions.

  • Evaluation and task modules can ship in installed wheels.
  • A test checks included Python folders for missing package markers.

Reviews (1) · Last reviewed commit: "Require an __init__.py in every installe..." · Reviewed by Greptile

@arena-review-bot

Copy link
Copy Markdown
Contributor

The PR changed while this review was running. Please run /review to retry.

The wheel is built with namespaces = false, so directories without an __init__.py are left out of non-editable installs. Add the three missing ones and a test that fails on any new one, with an allowlist for the unpackaged test directories.

Signed-off-by: David Tingdahl <dtingdahl@nvidia.com>
Signed-off-by: David Tingdahl <dtingdahl@nvidia.com>
@david-tingdahl-nvidia
david-tingdahl-nvidia force-pushed the dtingdahl/ci/require-init-py-in-packages branch from b5d5c31 to e867a37 Compare November 16, 2026 10:40
@david-tingdahl-nvidia david-tingdahl-nvidia changed the title Require an __init__.py in every installed Python directory Ensure all sub-packages are installed by pip Nov 18, 2026

@cvolkcvolk cvolkcvolk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…discovery

The robolab directory has no .py files of its own, so the layout test skipped it
and setuptools dropped robolab/run_benchmark from the wheel. Add robolab/__init__.py
and compare against find_packages() so missing parent packages are caught.

Signed-off-by: David Tingdahl <dtingdahl@nvidia.com>
@david-tingdahl-nvidia
david-tingdahl-nvidia enabled auto-merge (squash) November 18, 2026 16:51
@david-tingdahl-nvidia
david-tingdahl-nvidia merged commit 07a923c into main Nov 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants