Repository navigation
Ensure all sub-packages are installed by pip - #1668
Merged
david-tingdahl-nvidia merged 3 commits intoNov 18, 2026
Merged
Conversation
david-tingdahl-nvidia
requested review from
alexmillane,
cvolkcvolk,
peterd-NV,
qianl-nv,
viiik-inside,
xyao-nv and
zhx06
as code owners
November 12, 2026 10:17
Contributor
[Medium impact] The PR affects which Arena modules are available from non-editable wheel installs. The PR appears safe to merge, with a non-blocking gap in the packaging check. Findings
SummaryAdds three package initializers and two tests that check the source tree for missing initializers and stale exceptions.
Reviews (1) · Last reviewed commit: "Require an __init__.py in every installe..." · Reviewed by Greptile |
Contributor
|
The PR changed while this review was running. Please run |
The wheel is built with namespaces = false, so directories without an __init__.py are left out of non-editable installs. Add the three missing ones and a test that fails on any new one, with an allowlist for the unpackaged test directories. Signed-off-by: David Tingdahl <dtingdahl@nvidia.com>
Signed-off-by: David Tingdahl <dtingdahl@nvidia.com>
david-tingdahl-nvidia
force-pushed
the
dtingdahl/ci/require-init-py-in-packages
branch
from
November 16, 2026 10:40
b5d5c31 to
e867a37
Compare
…discovery The robolab directory has no .py files of its own, so the layout test skipped it and setuptools dropped robolab/run_benchmark from the wheel. Add robolab/__init__.py and compare against find_packages() so missing parent packages are caught. Signed-off-by: David Tingdahl <dtingdahl@nvidia.com>
david-tingdahl-nvidia
enabled auto-merge (squash)
November 18, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure all sub-packages are installed by pip
Why this change?
Setuptools skips any directory without an
__init__.pyand they are ignored bypip install. Editable modepip install -estill work, because Python imports straight from the mounted source tree.What changes?
__init__.pyto missing directoriesisaaclab_arena/tests/test_package_layout.py. It reads the include globs frompyproject.tomland fails for any directory under them that has.pyfiles but no__init__.py.