Repository navigation
Fix hang in L-island kitchen scenes - #1697
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe PR turns off physics scenes embedded in spawned backgrounds to prevent multi-environment simulations from hanging.
Reviews (1) · Last reviewed commit: "narrow the background physics-scene fix" · Reviewed by Greptile |
🤖 Isaac Lab-Arena Review BotSummaryThe spawner Design, Boundaries & Scope
Findings🔵 Improvement: isaaclab_arena/assets/background.py:152 — Scenes are only deactivated when Other notes:
VerdictShip it |
david-tingdahl-nvidia
left a comment
There was a problem hiding this comment.
Thanks for fixing this
Signed-off-by: zhx06 <zihaox@nvidia.com>
Signed-off-by: zhx06 <zihaox@nvidia.com>
Signed-off-by: zhx06 <zihaox@nvidia.com>
547f081 to
73c79bd
Compare
Fix a hang when a background USD contains its own
PhysicsScene: deactivate those scenes when the background spawns.Why this change?
kitchen_l_island.usda, used byreplicator_kitchen_l_island, has aPhysicsSceneunder its default prim.Backgroundis spawned into every environment, so 30 environments add 30 PhysX scenes next to the simulation's/physicsScene. The first physics step inPhysxManager._warmup_and_create_viewsthen never returns. Isaac Lab removes existing scenes only whenSimulationContextis created, which is before assets are spawned.This is the hang that made the nightly
placement-subsetrun time out atkitchen_bench_replicator_l_island_bowl_sink(#1696).Fixes #[issue number]
What changes?
_spawn_from_usd_with_resettable_nested_physics, the spawnerBackgrounduses by default, now deactivates the physics scenes under the spawned background before it is cloned. The simulation's/physicsSceneis then the only active scene.Backgrounds created with
reset_nested_physics=Falsekeep Isaac Lab's spawner and are not covered. None of them has its own scene today. The asset should still drop its scene.Validation
kitchen_bench_replicator_l_island_bowl_sinkandkitchen_bench_replicator_l_island_mustard_bowlwith 30 environments hang onmainand complete with this change.placement_subset_experiment.yamlcompletes all 10 Runs and writes the placement KPIs.main.