Repository navigation
revert: drop lock-screen approval actions (#107) - #109
Merged
Merged
Conversation
This reverts commit cf994a1. The fork has no push delivery path and the user dropped building one, so the actions could never fire.
[Medium impact] The revert appears safe to merge. SummaryReverts lock-screen approval actions and their supporting HTTP, mobile, and relay code.
Reviews (1) · Last reviewed commit: "Revert lock-screen approval actions (#10..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The fork has no push delivery path: no relay and no Firebase or APNs project. The user decided not to build one. Without delivery, the lock-screen Allow once and Decline actions from #107 can never fire, so this removes them.
What changed
cf994a16803) in full: the mobile notification actions, the HTTP respond endpoint,UserCommandDispatch, the relay payload fields, the expo-notifications patch change, and its docs.Scope
5d6f358859(feat(web): Fleet board for Home's chiefs of staff #108's merge), whose PR head passed all 31 checks.Verification
git rev-parse HEAD^{tree}equals5d6f358859^{tree}(3d644cc0f5).Model and harness: Claude Opus 5.5 (revert) via Claude Code in T3 Code.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.