Skip to content

revert: drop lock-screen approval actions (#107) - #109

Merged
eyeveil merged 1 commit into
mainfrom
revert/lockscreen-approvals
Nov 14, 2026
Merged

eyeveil merged 1 commit into
mainfrom
revert/lockscreen-approvals

Conversation

@eyeveil

@eyeveil eyeveil commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The fork has no push delivery path: no relay and no Firebase or APNs project. The user decided not to build one. Without delivery, the lock-screen Allow once and Decline actions from #107 can never fire, so this removes them.

What changed

Scope

Verification

  • git rev-parse HEAD^{tree} equals 5d6f358859^{tree} (3d644cc0f5).

Model and harness: Claude Opus 5.5 (revert) via Claude Code in T3 Code.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

This reverts commit cf994a1. The fork has no push delivery path and the user dropped building one, so the actions could never fire.
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 14, 2026
@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The revert appears safe to merge.

Summary

Reverts lock-screen approval actions and their supporting HTTP, mobile, and relay code.

  • Mobile approval choices stay on the thread instead of alerts.
  • Push messages carry activity details without approval-answer data.
  • Mobile approval answers no longer travel through a runtime-request HTTP route.

eyeveil explicitly states that removing approval actions and their supporting delivery behavior is intentional because the fork has no push delivery path.

Reviews (1) · Last reviewed commit: "Revert lock-screen approval actions (#10..." · Reviewed by Greptile

@eyeveil
eyeveil merged commit 0a92218 into main Nov 14, 2026
31 of 32 checks passed
@eyeveil
eyeveil deleted the revert/lockscreen-approvals branch November 14, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant