Repository navigation
feat(sdk): webhooks, XML, KuDE en cinta y ciudades por departamento - #5
Merged
Merged
Conversation
Regenera los tipos desde el OpenAPI actual y agrega los endpoints que el SDK no cubría: - webhooks: listar, crear, consultar, actualizar, eliminar, rotar el secreto y listar entregas. crear y rotarSecreto no admiten Idempotency-Key, así que un corte de conexión no los repite. - documentos.descargarXml, descargarKudeTicket y descargarKudeTicketImagen. - catalogos.ciudadesDeDepartamento. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenera
src/generado/types.gen.tscontra el OpenAPI actual, que ya incluye los tipos de webhooks. Con esto, el SDK cubre todo el OpenAPI de integración, salvo elplan-consumodeprecado.new Sifende(…) documentos emitir, consultarEstado, descargarKude, cancelar, nominar, inutilizar, … + descargarXml(cdc) → string + descargarKudeTicket(cdc, { ancho, resumen }) → Uint8Array (PDF) + descargarKudeTicketImagen(cdc, { puntos, resumen }) → Uint8Array (PNG) catalogos departamentos, distritos, ciudades + ciudadesDeDepartamento(id) + webhooks + listar, crear, consultar, actualizar, eliminar, rotarSecreto, listarEntregascrearyrotarSecretono admitenIdempotency-Key, así que viajan sin clave y el SDK no los repite ante un corte. Esto sigue la regla que ya existía: sin clave, solo se reintentan las consultas.Solicitudagregaacepta, para fijar elAcceptde cada descarga, y los métodosPUTyDELETE.Es el mismo cambio que ithdev/sifende-go#1.
Evidence
types.gen.tssin los tipos de webhooks.After: 57 tests.
lint,typecheck,buildypublintpasan. Entre los nuevos:dist/contraapi.sifende.com.py:ciudadesDeDepartamento(11)devuelve 387 ciudades, ywebhooks.listar()con una clave inválida daSifendeApiError 401.Merge Danger
Door: two-way
Solo agrega métodos y exports. Los tipos regenerados quitan alias que el SDK no usaba (por ejemplo
NominarByCdcData) y actualizan otros al spec actual. Un consumidor que importara esos alias generados de@sifende/sdktendría que ajustarlos.Blast Radius: tipos
No cambia nada en runtime para quien ya usa el SDK. Se publica en npm recién al crear un Release
v0.2.0con elpackage.jsonactualizado.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.