Repository navigation
Deja de registrar el tráfico HTTP completo por defecto - #4
Merged
Merged
Conversation
TuRuc always added an HttpLoggingInterceptor at BODY level, so every lookup wrote the full request and response, including taxpayer data, to the consumer's logs with no way to turn it off. Default to no logging and add TuRuc.withLogLevel(Level) to opt in. logging-interceptor becomes an api dependency because Level is part of the public API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TuRuc.getClient()agregaba siempre unHttpLoggingInterceptorenBODY. Así, cada consulta escribía en el log de quien usa la librería la petición y la respuesta completas, con RUC, razón social y estado, y no había forma de desactivarlo.Uso para depurar:
Evidence
Los tests capturan el logger
okhttp3.OkHttpClientdejava.util.logging:withLogLevelde prueba que no cambiaba nada,doesNotLogRequestsByDefaultfalla (se registra el cuerpo) →12 tests completed, 1 failed.After:
doesNotLogRequestsByDefault,logsResponseBodyWhenRequestedyrejectsNullLogLevelpasan →12 tests, 0 failures.clean build(Spotless, PMD,-Werror) pasa.Merge Danger
Door: two-way
Va antes de la primera publicación en Maven Central (PR #3), para que la 0.1.0 no salga registrando datos de contribuyentes.
Blast Radius: Consumidores
Quien dependía de esos logs tiene que activarlos con
withLogLevel. El README y el CHANGELOG lo documentan.🤖 Generated with Claude Code