Source config as custom attribute - #23
Merged
jeppekroghitk merged 7 commits intoSep 14, 2026
Merged
Conversation
rimi-itk
reviewed
Sep 14, 2026
Comment on lines
+10
to
+11
| #[\Attribute(\Attribute::TARGET_CLASS)] | ||
| final readonly class AsDataSource extends Definition |
Contributor
There was a problem hiding this comment.
Any specific reasons for introducing the AsDataSource class? We can just use Definition as an attribute.
Collaborator
Author
There was a problem hiding this comment.
Just to adhere to Symfonys naming conventions. Nothing functional.
jeppekroghitk
deleted the
feature/8191-source-config-as-custom-attribute
branch
September 14, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
#8191
Description
Screenshot of the result
N/A
Checklist