Add pagination to datacontroller - #33
Closed
jeppekroghitk wants to merge 1 commit into
Closed
jeppekroghitk wants to merge 1 commit into
jeppekroghitk wants to merge 1 commit into
Conversation
The broker answers a list request with its first page — fifty entities — and advertises the rest in a Link header. A map widget asks for its layer once and draws what it gets, so the map quietly showed a fraction of the data. Raising the limit is no way out either: the broker refuses a limit above its own maximum with 403 TooManyResults. A request carrying "all" is now answered with every page, followed and merged in PagedBrokerReader. Anything else is proxied exactly as before, so a client passing its own limit and offset keeps paging for itself. The run gives up after a hundred pages in case a broker keeps announcing another one, and says so in the log rather than passing off a truncated set as the whole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
#8191
Description
Screenshot of the result
N/A
Checklist