Repository navigation
Conversation
Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a86c8682e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| import { | ||
| to = module.repository_policy.github_repository.managed_settings["jackin-marketplace"] |
There was a problem hiding this comment.
When repository_policies is overridden to the eight repositories accepted by mandatory_target_repositories_present, the module's for_each creates no jackin-marketplace instance, but this unconditional import still targets one, causing tofu plan to fail instead of managing that otherwise-valid inventory. OpenTofu requires every import target to have corresponding resource configuration (OpenTofu import documentation); make these marketplace imports conditional on the configured keys or require marketplace in the inventory.
Useful? React with 👍 / 👎.
|
Three-root layout retained; salvage noted in unification plan (imports.tf pattern + inventory-guards, minus verify-policy.sh stages). Closing unmerged. |
This change adopts the nine existing GitHub repositories and their 18 rulesets through provider-documented import blocks, so an empty local state no longer plans duplicate creates. Every inventory entry now receives repository settings plus both rulesets; the settings-only disposition has been removed. Repository visibility is explicitly managed from the inventory, required CI contexts cannot be empty, and both rulesets depend on the managed repository resource.
Validation:
tofu fmt -check -recursiveandbash tests/verify-policy.shpass. A fresh provider-backed plan from empty local state reports 27 imports and 27 no-op resource actions, with zero creates, updates, or destroys. No apply has been run. This repository uses the default local backend (tofu init -backend=falsein CI); no remote backend was introduced.