Repository navigation
Document that SlideShowView::addImage is main thread only - #69
Merged
Merged
Conversation
The remarks said that addImage may be called from a background thread, but it adds to an Array without a lock while render reads the same Array on the main thread. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change accurately describes the existing threading constraint and has no unresolved findings.
No open issues 🎉
What changed in this PR
Corrects the threading contract for SlideShowView::addImage without changing runtime behavior.
Changes:
- Replaces the thread-safety claim with a main-thread requirement and guidance for workers to use a guarded queue.
| File | Description |
|---|---|
| Sources/ObjectivelyMVC/SlideShowView.h | Corrects the addImage documentation to reflect unsynchronized image access. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@remarksonSlideShowView::addImagesaid that it is thread-safe and may be called from a background thread. It is not: it adds to anArraywith no lock, andrenderreads the sameArrayon the main thread.This changes only the doc comment. Quetoo's installer and its new
MapshotThumbnailViewalready collect images in a locked queue on the worker and add them on the main thread.🤖 Generated with Claude Code