Repository navigation
Train 27: #603 - #605
Merged
Merged
Train 27: #603#605
Conversation
jinja2.meta.find_undeclared_variables for Jinja2C++: the source is parsed again and the parse's NameResolver reports the names read or stored in a branch that no store, frame around them or binder declares, without the environment's globals. Trans variables and message names are now reads of the resolver too, a set block in a loop's else stores in the else's frame, and imported names besides their alias get a store kind of their own. Template.module is filed as 0284. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XALEgQvXdN6pfE79XkgggV
Codex review of #603: replace per-read scans of a frame's stores with an index of each name's first store per frame and of the frames that read a macro's special names, so the check is linear (5,000 sets: 0.5 s -> 29 ms in Debug). A set block's filters now read in the block's frame, so a later store in it hides the outer name as in Jinja2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XALEgQvXdN6pfE79XkgggV
Regenerate the task index. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTQTriEsFrrBgcYNKDUUF4
|
To use Codex here, create an environment for this repo. |
rmorozov
marked this pull request as ready for review
October 19, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Train of one (master 941c91c, after train 26): #603 (0236
Template::FindUndeclaredVariables, head a54c8a4) was green on the older base 3985100 and overlapsdocs/parity.mdwith train 26, so it gets one CI run on the current master. Merged without conflicts; regenerated the task index; parity table unchanged (1939 templates); 0236 already done. ctest 3/3 locally.Codex: result with no open P0/P1 (two P2 answered, later re-reviews clean).
@codex security reviewstarted a plain review, so no separate security result.Roles: steward only.
Generated by Claude Code