Repository navigation
Merge train 29: Settings::Limits (#601) - #610
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…Load, output checked per step With every limit at its default a render takes no new per-step work: a render with limits makes CheckStack take its slow path, which counts the step and checks the output size. Parse limits live in a thread-local set for the Load. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…nternal sequence cap Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…9 loop in the defaults pass Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…s uint64 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…ds as uint64 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…elector and the cycle collector); close 0262 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
…rce; parse limits in FindUndeclaredVariables Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USAwpuAiFNpCMNpcRmwvsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Train of one: #601 (0262 Settings::Limits) on master 93c0934, merged with --no-ff. Its base was stale (contained 9cf8586, before train 28's ABI namespace).
Conflicts resolved by the steward:
recursion_guard.handtemplate_dict.hboth kept, sorted).ThrowSequenceTooLongnow sits insideinline namespace v2.python3 scripts/abi_namespace.pyre-run on the train: 0 files rewritten.Task index regenerated (0262 done, 0282 added); docs/parity.md count unchanged (1995). Local: build clean, 4/4 ctest binaries pass, clang-format clean.
Roles: no subagents; no verifier round on the train itself (owner ran theirs). Codex on #601: 2 findings, both fixed, re-review clean. Perf track: approved at f3b25cd (Render/plain_text +0.76% named exception). Red pushes: none so far.
Known overlap for later: #597 (0253) also adds
ResourceLimitExceeded = 18and changes the catch blocks in src/template_impl.h Render; it will need to rebase over this train.Generated by Claude Code