Repository navigation
fix(skills): owner /skillsuggest reject is archived:owner-rejected, not verdict:reject (#2373) - #2375
Merged
Merged
Conversation
…2373) #2283 recorded the owner's P3 reject as verdict:reject, but Wiki DOC-3903 TM-3906 reserves verdict:* for the P6 fleet intake review (publisher ledger a2a-verdict). One stage name meant two events, and owner rejects were missing from the report's archive_reasons. - skillsuggest SKILL.md: reject writes lifecycle archived:owner-rejected. - skill-review.sh reindex: a .rejected-<ts> draft maps to archived:owner-rejected; a pre-#2373 meta verdict:reject is no longer adopted. - ccc-skill-usage-report.py: node rows and aggregate (incl. reports from nodes not yet updated) read a node-index verdict:reject as archived:owner-rejected. - docs + changelog; skills/registry.json regenerated. Publisher ledger verdict:* unchanged; no field, directory or gate change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jinon86
approved these changes
Oct 18, 2026
jinon86
left a comment
jinon86
left a comment
Contributor
There was a problem hiding this comment.
Approved after exact-head validation and fresh operator authorization using the relay-held jinon86 credential.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2373 — follow-up to #2283 (#2368 "open choice": owner manual reject →
verdict:reject).Why
Wiki DOC-3903 TM-3906 defines
verdict:{approve|revise|reject}as the P6 fleet intake review (publisher ledgera2a-verdict,scripts/ccc-skill-promotion.py:1648-1651). An owner/skillsuggestreject is the P3 human gate, and that draft never leaves the node. Using one name for both events would:drafted → verdict:rejecttransition that skips P4/P5,archive_reasons.Owner decision 2026-10-18: option 2 — a new archive reason
archived:owner-rejected.Change
skills/skillsuggest/SKILL.mdlifecycle: "archived:owner-rejected"(+skills/registry.jsonregenerated)claude/hooks/skill-review.sh(reindex).rejected-<ts>draft →archived:owner-rejected; a meta value is adopted only if it isarchived:*, so a pre-#2373verdict:rejectis remappedscripts/ccc-skill-usage-report.py_NODE_INDEX_STAGE_ALIASES: a node-indexverdict:rejectrow and a legacystatus: rejectedrow →archived:owner-rejected;aggregateapplies the same alias to reports from nodes that have not updated yet (counts merged)docs/skill-usage-report.md,changelog.d/2373-…Unchanged: the publisher ledger's
verdict:*(P6), all fields, directory suffixes, gates and caps. The owner-approveapprovedlabel is tracked separately in #2374.Evidence (nosuk, load avg 0.55–1.22)
scripts/ccc_skill_usage_report_test.py: 18 OK. The node fixture has averdict:rejectrow (→archived:owner-rejected: 2); the aggregate fixture includes a not-yet-updated node reportingverdict:reject(→archive_reasonsowner-rejected 3, noverdict:rejectstage, "archive reasons: 7").scripts/ccc-skill-autosave.test.sh: 199/0, including 2 new fix(skills): 오너 수동 거절 lifecycle을 verdict:reject → archived:owner-rejected로 분리 (#2283 후속) #2373 reindex assertions (pre-fix(skills): 오너 수동 거절 lifecycle을 verdict:reject → archived:owner-rejected로 분리 (#2283 후속) #2373 metaverdict:rejectremapped; noverdict:*in the node index).claude/hooks/skill-review.test.sh73/0,scripts/ccc-skill-registry.test.sh26/0,ccc-skill-registry.py validateok.mainsources): exactly the changed/new assertions fail — shell 196/3 (the updated suffix-wins assertion + 2 new), pytest 2 failures (test_node_counts…,test_aggregate…).CCC_HARNESS_PHASE=static validate-harness.sh: PASS.Live effect on nosuk after deploy: the 5 owner rejects from 2026-08-25/26 move from
verdict:rejecttoarchived:owner-rejectedon the next reindex sweep.🤖 Generated with Claude Code