Stop printing PASS when deployment-safety checks only warn - #34
Merged
Conversation
A private-LAN or --skip-listen run is warnings-only, not a clean success, so the banner is now WARN deployment safety. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_deployment_safety.pyprintedPASS deployment safety (warnings)for warnings-only runs, so a hostile private-LAN config still looked like success.WARN deployment safetywhenworst_statusis warn. Clean pass still printsPASS; fail still printsFAILand exits 1. Warnings-only still exits 0 so CI--skip-listenstays green.test_warnings_only_does_not_print_pass(private LANhttp://192.168.1.10:11434) plustest_skip_listen_exits_0_on_current_reponow assert the output does not containPASS deployment safety.Leftover #5
MAX_BYTES, leftovers #18/#19 live rates, downstairs GPU, and Halo 4 were not touched.Test plan
PYTHONPATH=src python3 -m unittest tests.test_deployment_safety_ci tests.test_safety -vPYTHONPATH=src python3 scripts/check_deployment_safety.py --skip-listenprintsWARN deployment safetyand exits 0Made with Cursor