Repository navigation
Confirm joining trips in a dialog - #532
Merged
Merged
Conversation
On phones the armed "Tap again to join" label pushed the trip's buttons onto a row of their own. The join button now only asks, and the trip log page confirms in a dialog that says the join cannot be undone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The address lookup retries in rounds while the mocked API returns no addresses. Pages left mounted kept asking in later tests, which made "asks for no addresses while place names are switched off" flaky in CI. Unmounting stops the lookup, as it does when the page closes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On phones the armed Tap again to join label made the trip card's map, hide and join buttons wrap onto a row of their own.
joinNextConfirmnow reads "Join trips" / "Ritten samenvoegen"; the--keptlabel modifier is gone.🤖 Generated with Claude Code