Repository navigation
Account for cancellation in dot precision tests - #387
Merged
Merged
Conversation
The BigFloat dot kernel compensates the sum of rounded products. Product rounding errors can be large relative to a nearly cancelling dot product, so the previous relative-error check could fail for valid results. Normalize by the sum of absolute products computed at higher precision, and add a deterministic cancellation regression. Replayed the exact failing RNG state from PR #386 and twenty additional seeds. The modified numeric test file also passes on Julia 1.10.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 23 23
Lines 2396 2396
=======================================
Hits 2207 2207
Misses 189 189 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BigFloat dot kernel compensates the sum of rounded products. Product rounding errors can be large relative to a nearly cancelling dot product, so the previous relative-error check could fail for valid results. Normalize by the sum of absolute products computed at higher precision, and add a deterministic cancellation regression.
Replayed the exact failing RNG state from PR #386 and twenty additional seeds.