Repository navigation
feat: todo burndown: handle the oldest (≤10) TODO/FIXME/XXX/HACK - #351
Merged
Merged
Conversation
Log a t.Stop error from the deferred cleanup. Stop tailing a file when a line cannot be written to the destination, since a broken destination will not recover. tailFile now takes an io.Writer so it can be tested with a failing writer.
Add a test that tails into a writer that always fails and checks that tailFile returns and logs the write error. Check the Close and Write errors that errcheck flagged.
Setup writes and directory creation now fail the test through small helpers, and best-effort teardown is explicit about ignoring errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pay down the oldest TODO/FIXME/XXX/HACK comments (up to 10, oldest first by
git blame) so the ones left are meant. The repository has exactly one such comment, so this run handles that one. Because its fix touches 46 call sites in 7 files, it is split into small per-file steps. The last step re-enables the linter and deletes the comment.What changes
Testing
tailFilestopping on a write error, andgenerateFileoutput staying intact after the close change.go test -race./...(unit and e2e, asmake testand CI do).golangci-lint run./...with errcheck enabled in CI.