Repository navigation
feat: bring every Go toolchain pin to go1.27.2 (the latest stable - #353
Merged
Merged
Conversation
Pin the Dockerfile builder to golang:1.27.2 to match the go directive in go.mod, and add a test that fails when the two drift apart. govulncheck -show verbose reports one module-level finding, GO-2026-5932 (golang.org/x/crypto v0.57.0, openpgp package, no fixed version). No reachable vulnerabilities are found.
Replace the var-and-errors.As pattern with the generic errors.AsType in the exit code paths and tests, and cover an ExitError wrapped with %w.
Move the func map merge into templateFuncMap so it can be tested, and copy dockerize's functions over sprig's with maps.Copy. Add a test that every dockerize function, including those that shadow sprig names, is the one in the merged map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Where the toolchain is pinned today (master d9fd48f):
What changes
Result
Bring every Go toolchain pin in dockerize to go1.27.2, the newest stable release (go.dev/dl lists go1.27.2 and go1.26.9 as of 2026-10-16). go1.27.2 carries security fixes to
crypto/tls,html/template,net/http,net/textproto,osand thegocommand. dockerize usesnet/httpin its HTTP wait checks (waitForHTTP), so the binaries and the Docker image should be built with it. After the bump, adopt the newer std idioms themodernizeanalyzer suggests, one per step.Testing
Every step runs the full suite before it's committed:
go test -v -race./..., which includes thee2e/packagegolangci-lint run./...with the repo's.golangci.ymlgo vet./...andgovulncheck./...go buildfor linux/darwin × amd64/arm64, as in CIdocker build.and checks--versionand--helpon the image.