Repository navigation
feat: testing audit of dockerize (plan): find untested risky code - #354
Merged
Merged
Conversation
…bprocess Add resetGlobals to snapshot and restore the package globals tests mutate, replacing hand-written save/restore in the wait, template and process tests. Add runFatalCase, which re-runs a test binary to check log.Fatalf paths. Mark tests that touch no globals as parallel.
Make the kill timeout in signalProcessWithTimeout a package variable so tests can shorten it. Replace the Signal(0)-only test with cases that check SIGTERM is delivered and that a process ignoring TERM is killed with SIGKILL after the timeout.
…e and version paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 7 findings from the Testing audit (testing v1) at
d9fd48f, each in a small, easy-to-review step with a test. Make the test suite something to trust: risky code is covered, every test can fail, and the suite is fast and stable enough that people run it. Unticked findings stay in the backlog for a later run.What changes
Testing
Every step adds a test that fails before its fix (or shows the finding no longer reproduces) and runs the project's full existing test suite. A refactor step keeps behaviour, so the existing tests prove it.