Repository navigation
fix(a2a): return not found for expired and missing sessions - #3231
Merged
Merged
Conversation
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
EItanya
reviewed
Oct 15, 2026
| Agent: &apiv1.ResourceReference{Namespace: agent.Namespace, Name: agent.Name}} | ||
| sessionStore := &serviceTestStore{getResult: stored} | ||
| authorizer := &recordingAuthorizer{denied: map[string]bool{id: true}} | ||
| if test.name == "missing session" { |
Contributor
There was a problem hiding this comment.
I can't believe I'm reviewing test code again lol, but this feels like a smell
Contributor
Author
There was a problem hiding this comment.
Fixed it, I'll need to start looking at Codex's test changes 😂 ...
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
EItanya
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing an expired or missing session by
contextIdpreviously returned permission denied, while usingtaskIdreturned task not found.Map A2A service-level not-found errors consistently to
TaskNotFound(-32001, gRPCNOT_FOUND), including missing Agents. Agent-card HTTP discovery now returns 404. Authorization failures retain permission-denied responses, and ownership filtering remains intact.