Repository navigation
fix(ui): show one loading state in the agent switcher - #3237
Open
vedantlavale wants to merge 1 commit into
Open
vedantlavale wants to merge 1 commit into
vedantlavale wants to merge 1 commit into
Conversation
Hold the agents read until namespaces are known, combine both reads into one loading state, and report failures as errors instead of an empty cluster. Closes kagent-dev#3217 Signed-off-by: vedantlavale <vedantlavale@gmail.com>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3217
What changed
The agent switcher fired its agents read with an empty namespace list while namespaces were still loading, so the panel first claimed the cluster had no other agents, then went blank, then listed them. It now holds the read until namespaces arrive and shows one loading placeholder until both reads land. A failed read reports an error instead of an empty cluster.
How it was tested
yarn vitest run src/components/agent/AgentSwitcher.test.tsx— 7 passed.yarn typecheck— passed.yarn lint— 0 errors (6 pre-existing warnings).git diff --check— passed.?mock=slow) on the same chat route, mid-load: base at1eb89fb1, this branch.Before and after
Risks and follow-ups
UI-only change. No API, persistence, or conversation lifecycle impact.