Repository navigation
Conversation
Signed-off-by: YamonBot <141118378+YamonBot@users.noreply.github.com>
EItanya
reviewed
Oct 16, 2026
|
|
||
| providers: | ||
| # Each provider can set `stream: false` to disable LLM response streaming. | ||
| # When omitted, ModelConfig uses its API default (true). |
Contributor
There was a problem hiding this comment.
Can you add the value here so it's documented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ModelConfig already supports
spec.stream, but the Helm template ignores a provider's explicit streaming option. An OpenAI-compatible provider that needs non-streaming responses cannot be configured through chart values.Change
Render
spec.streamonly when the selected provider defines the key.hasKeypreserves explicitfalse; omitted values retain the existing API default. Document the provider option and cover omitted, false, true, and a second provider.Validation
make helm-version VERSION=1.0.0-alpha13untt-macos-arm64 -f 'tests/modelconfig_test.yaml' helm/kagent— 18 tests passed.git diff --checkNo CRD or runtime API change. Commit is DCO signed off.