Conversation
13 tasks
briehl
approved these changes
Sep 10, 2026
briehl
left a comment
briehl
left a comment
Member
There was a problem hiding this comment.
It's just a copy change in kbase/ui, right? It didn't do anything forceful like narrative, did it?
Collaborator
Author
|
@briehl correct |
Collaborator
Author
|
Rerunning checks then merging |
The account Log In Sessions tab stated sessions remain active for two weeks. Token lifetime is being extended to four weeks, so update the user-facing copy to match. The session tables already render the real server-provided expiration, so no logic change is needed.
dauglyon
force-pushed
the
fix/token-lifetime-four-weeks
branch
from
September 10, 2026 21:12
13ec8b8 to
9c1fc6b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KBase is extending the login/auth token lifetime from two weeks to four weeks. The account Log In Sessions tab hardcodes "two weeks" in its explanatory tooltip, which becomes incorrect after the change.
This updates that user-facing copy to say four weeks. No logic changes: the session tables already render each token's real, server-provided
expires, so they track the actual lifetime automatically.Changes
src/features/account/LogInSessions.tsx— tooltip copy "two weeks" → "four weeks" (text only; prettier reflowed the wrapped lines).Context
Part of a small cross-repo sweep for hardcoded token-lifetime assumptions. This was the only such assumption in this repo — everything else reads the server-provided expiration. A companion PR in kbase/narrative removes a hardcoded 14-day cookie fallback.