Document all live view CSP domains - #541
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Risk assessment: Very Low
Decision: Approve.
What changed: A 6-line edit in browsers/live-view.mdx updates the live-view iframe CSP example. The callout now names both *.onkernel.com:8443 and *.kernel.sh:8443, and the sample frame-src / connect-src directives add the matching HTTPS and WSS kernel.sh entries.
Why this is Very Low:
- Documentation-only MDX on the docs site; no application, API, or infrastructure code.
- Isolated to one embedding callout; no shared libraries, auth, billing, or production logic.
- No CODEOWNERS file in this repo.
- Blast radius is reader-facing CSP guidance only.
No existing approval to preserve. Approving on that basis.
Sent by Cursor Automation: Assign PR reviewers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.kernel.sh:8443to the iframe and WebSocket CSP directivesTesting
mint broken-linksbrowser_live_view_urlredirect, and confirmed both loaded with HTTP 200