fix(tree-compare): default Base to the older revision - #2139
Open
felipebergamin wants to merge 2 commits into
Open
felipebergamin wants to merge 2 commits into
felipebergamin wants to merge 2 commits into
Conversation
The compare page defaulted side A to the branch head and side B to the previous revision, while deriveCompareChange reads A as the 'from' side. A test that started failing on the newest revision was therefore classified as 'fixed' instead of a regression. Default side B to the branch head and side A to the revision before it, and pre-fill the current revision as side B when opening compare from Tree Details, so the default A -> B direction is oldest -> newest. Closes kernelci#2130
Side A/B hid the comparison direction. Use Base (from) and Target (to) in the selector, tables, and drawer; URL params stay hashA/hashB.
felipebergamin
marked this pull request as ready for review
September 25, 2026 18:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Tree compare treated A as “from” and B as “to”, but defaulted A to the branch head and B to the previous revision. A failure on the newest checkout was therefore labelled fixed instead of a regression.
Defaults are now chronological: Base (
hashA) is the previous revision, Target (hashB) is the current/latest checkout. Opening compare from tree details pre-fills the viewed commit as Target. Selector, tables, and the details drawer say Base/Target instead of Side A/B.URL params stay
hashA/hashB. Once both hashes are set, they are not reordered by timestamp; only an explicit swap exchanges them. Change types (regression, fixed, …) follow Base → Target.Closes #2130
How to test
/tree?i=300), pick a tree’s latest checkout, click Compare revisions.Visual reference