config: runtime: tests: rt-tests: fix AFFINITY parameter name - #3226
Open
bhcopeland wants to merge 1 commit into
Open
bhcopeland wants to merge 1 commit into
bhcopeland wants to merge 1 commit into
Conversation
The parameter was spelled AFFINTIY, which the Linaro test-definitions rt-tests jobs do not declare, so LAVA dropped it and the scripts used the definition default of "0". With THREADS at 2 that pinned both cyclictest threads to CPU0 instead of spreading them over 0-1 as this template intends. cyclictest is the only one of the eleven rt-tests jobs that declares AFFINITY, so it is the only one whose behaviour changes. Treat its latency series as having a configuration discontinuity at this commit. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
bhcopeland
force-pushed
the
fix/rt-tests-affinity-typo
branch
from
September 26, 2026 09:19
4fe0d71 to
5601692
Compare
|
LGTM! |
roxell
approved these changes
Sep 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter was spelled AFFINTIY, which the Linaro test-definitions rt-tests jobs do not declare, so LAVA dropped it and the scripts used the definition default of "0". With THREADS at 2 that pinned both cyclictest threads to CPU0 instead of spreading them over 0-1 as this template intends.
Latency results either side of this change are not comparable.
@sebastianas and @sashalevin please review.
FWIW this currently is set to cover ALL rt tests