Repository navigation
Combine the open Claude PRs into one - #315
Merged
Merged
Conversation
When the GM ends a started combat, the active GM's client lists the defeated creatures (marked defeated, or Stamina or hit points at 0 or below; never a player's actor) one row per Chronicle page, each with what its drop list leaves, and puts the ticked ones in the party's spoils tray only on "Put in the tray". A creature with no page, or a page with no drop list, is listed but can't be ticked. "Not now" or closing sends nothing. Chronicle drops again on every call, so a confirmed prompt is one call, and a failed call is reported rather than retried. A combat whose tokens belong to a planned encounter with stages not yet started asks first whether the whole fight is over. Holding keeps the defeated on the scene until a later combat of that encounter ends with no stage left; each creature counts once however many combats it was in. The drop lists come from GET /crafting/spoils; a campaign with none gets no prompt. choiceDialog joins the dialog helpers for a window with several buttons, on DialogV2 with the V1 fallback. Part of #283 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxR6cJAZZ96JUUr1SkEE3C
A page removed in Chronicle moves its journal to "Chronicle: removed" without a word. The Overview now has an info row counting those journals, and it opens the pages list where each can be kept, pushed back or deleted. Refs #280 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CZefPemNkUZP2VPYJpNKF6
Chronicle's sky now paints through gl_shared.js (SharedGL), the page's one WebGL2 context and slow-device verdict, which the painted crafting benches share. Copy it into vendor/chronicle/ with the current sky files, all unchanged, and load it right before sky_gl.js in the Sky Clock and its test. Fixes #300 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CZefPi2DYXfRvFz1WymVFu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CZefPi2DYXfRvFz1WymVFu
Fixes found by reading the whole module and running the two-sided bench:
- A socket replaced by Save settings no longer clears or reconnects the
new one when its close arrives late (stale handlers now check they are
still the current socket).
- Players no longer get the status dot: it always read disconnected and
clicking it opened a keyless socket that retried every 30 seconds.
- Mentions of pages a player can't open show "a hidden page", not the name.
- Text before the first heading goes back to Chronicle without a sync-made
"Overview"/"Content" heading; page names in added headings are escaped.
- An identity item (kit, ancestry) the GM swapped in Foundry is left alone
until Chronicle's pick changes; the picks last applied are kept on the
actor.
- A map's own picture is copied into the world through PictureStore, since
Chronicle's signed links expire after 15 minutes.
- The GM layer row is kept out of player flags; tokens read hit points from
bar1_value/bar1_max.
- Chronicle's real-time refusal ("tracks real-world time") is recognised.
- Stash, crafting and shop requests from players are limited per player,
like quest requests.
- Test connection names a key for another campaign, and a page that isn't
Chronicle; the unreachable message covers mixed content.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CZefPfJdwbn2k1DtGMYyod
Security fix. A map's picture copied into the world's files stayed at the same address after the GM shadowed part of the map, and was copied even for a map journal no player could open. Now: - The picture is copied only once a player can open the map's journal; sharing the journal copies it then. Other maps keep the short-lived link. - When a map gains a shadow, the copy is overwritten with a one-pixel blank picture of the same name and format (Foundry can't delete files), and the store forgets it. The page records the id, so if the shadow is removed in a later session the real picture is written back. - The GM's own view of a newly shadowed map takes a fresh link instead of the blanked file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CZefPfJdwbn2k1DtGMYyod
…to claude/project-thread-261ujs
…to claude/project-thread-261ujs
…to claude/project-thread-261ujs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Key Maker · project thread
What and why
All open PRs merged into one branch, no conflicts: #314, #303, #293, #291. Originals stay open until this merges.
Tests
node --test tools/test-*.mjs: 1706 pass, 0 fail (4 skipped). The two-sided bench (bench/run.sh) was not run here.Still needs a hand check
TESTING.md, Live test session on Foundry v14 (after TESTING.md is brought up to date) #94).Generated by Claude Code