Repository navigation
Keep the shared tunnel when a Codex stream is cancelled after its final event - #2
Merged
Merged
Conversation
…al event A client that closes the stream right after response.completed cancelled the request before end-of-stream, so the silent-connection rule retired a healthy connection and every request opened a new tunnel. Codex readers now mark the response complete on response.completed/incomplete/failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ough the pool The image stream reader's mark is removed: images use the standard transport, so it was a no-op. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients that stop reading at
response.completed(e.g. the carehome-portal eval provider on oracle) cancel the request before end-of-stream. The round-7 silent-connection rule then retired a healthy conn, so oracle opened ~1 tunnel per request.helps.MarkResponseComplete(body)sets a flag on the tracked uTLS response body (unwrapping the usage TTFT wrapper);finish()skipsdropIfSilentwhen set.response.completed,response.incomplete,response.failed.Tests:
TestUtlsClientKeepsTheTunnelWhenAStreamIsCancelledAfterItsFinalEvent(5 requests → 1 tunnel; 5 with the fix reverted). Round-7 silent-stream retire test still passes.go test -race -count=3helps, Codex executor tests, vet, gofmt clean; go.mod/go.sum unchanged.Live on ovh via switchboard + Pi: 2 accounts × 10 requests cancelled after reading: 20 tunnels without the mark, 2 with it.
🤖 Generated with Claude Code
Review follow-up (3681a31)
{"type":"error"}event now also marks the reply complete.CodexExecutor.ExecuteStreamthrough the uTLS pool, a chatgpt.com TLS server and a CONNECT proxy:response.completeduse 1 tunnel. With the mark removed they use 5.response.createdstill has its tunnel retired, so 2 tunnels are opened.helps.SetUtlsRootCAsForTestlets those tests trust the local server../internal/runtime/executor.