Repository navigation
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Run directly, unittest.main() exits before a class defined below it exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rebuilt MoQ broadcast currently reuses an implicit route identity, allowing viewers to resume cached groups from another publisher instance. Mint an epoch with each broadcast, reuse it for announcements of that broadcast, and renew it only when rebuilding the publish side. No consumer-specific option is added.
Status: blocked on a published SDK
moq.Route(epoch=)andmoq.mint_epoch(feat(ffi)!: bindings expose publisher epochs; "epoch" means only that moq-dev/moq#5146) exist only on upstream moqmain. PyPI's moq-ffi 0.4.17 / moq-rs 0.5.1 are built from upstreamrelease, so this branch's CI fails pyright and every test that constructs a client. It cannot go green until a published SDK carries epochs.main's Python SDK also breaks this transport, independent of this PR. Measured at upstreamc01d8067, the unchanged base5ecad75e4passes 147/147 MoQ tests on the published SDK and fails 6 on a source build:AudioDecoderOutput(max_age_us=)becamemax_delay_us(feat!: name subscriber staleness max_delay; publisher retention keeps max_age moq-dev/moq#4917): 4 tests.BroadcastProducer.publish_json_streammoved tomoq.json.StreamProducer(refactor(ffi)!: the bindings mirror Rust's layers moq-dev/moq#4519):TestMOQAudioTrackRestartLive.str()through RustDisplay, so the test's ill-typedmoq.Error.Protocol("boom")(details must be aProtocolError) raises inside_error_message:test_any_other_subscribe_error_still_propagates.BroadcastConsumer.subscribe_catalogandsubscribe_json_streammoved tomoq.media/moq.json(refactor(ffi)!: the bindings mirror Rust's layers moq-dev/moq#4519). The MagicMock fakes accept the old names.moq/voice-timelineto that API; this PR rebases onto the migration; the agent's fork pin takes both.Validation at
207f86b82c01d8067: both new tests pass and fail without the change; full MoQ suite 143 pass, 6 fail (the six above, same as base).207f86b82only moves the new test class above the__main__guard.No package publication or PR to another organization is included.
Body rewritten over the earlier GPT-6 draft.
(Written by Claude Opus 5.5)