Rename --git-branch to --git-revision - #4048
Draft
gauron99 wants to merge 1 commit into
Draft
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
gauron99
force-pushed
the
git-revision-flag
branch
3 times, most recently
from
September 8, 2026 09:37
4b99ccc to
e09a50b
Compare
gauron99
changed the title
gauron99
marked this pull request as draft
September 8, 2026 11:06
knative-prow
Bot
added
the
do-not-merge/work-in-progress
gauron99
changed the title
A remote build from a repository can start from a branch, a tag or a commit, which git's fetch takes alike, so deploy's flag for it is --git-revision (FUNC_GIT_REVISION), matching the build.git.revision key of func.yaml. config git set follows for the name, with a TODO: its value is the branch Pipelines-as-Code reacts to, not a revision, and should become a key of its own. The MCP tools follow: gitBranch and git_branch are gitRevision and git_revision.
gauron99
changed the title
gauron99
force-pushed
the
git-revision-flag
branch
from
September 8, 2026 14:21
e09a50b to
130075f
Compare
Contributor
Author
|
/retest |
lkingland
reviewed
Sep 9, 2026
lkingland
left a comment
lkingland
left a comment
Member
There was a problem hiding this comment.
Looking good!
I might consider going even more fundamental: --revision (and later --source)
After all, there's no gurantee git will be the defacto choice forever, and we could in theory back --source with something other than a VCS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
func deploy --remote --git-urlbuilds a repository at a branch, a tag or a commit, which git's fetch takes alike, so the flag naming it is now--git-revision(FUNC_GIT_REVISION), matching thebuild.git.revisionkey offunc.yaml.func config git setfollows for the name. The MCPdeployandconfig_git_settools follow:gitBranchandgit_branchbecomegitRevisionandgit_revision.config git setgets a TODO at the flag: its value is the branch whose pushes Pipelines-as-Code builds, a trigger filter matched against pushed refs, not a revision. It sharesbuild.git.revisionwith deploy only because both persist to the same key; it should become a key of its own, and the PAC deploy step should stamp the revision it built from the push event.Behaviour is otherwise unchanged.
/kind cleanup
Relates to #3203
Release Note
Docs