Skip to content

test: remove coverage thresholds so coverage stays informational - #138

Merged
knowledgecode merged 1 commit into
masterfrom
develop
Sep 6, 2026
Merged

test: remove coverage thresholds so coverage stays informational#138
knowledgecode merged 1 commit into
masterfrom
develop

Conversation

@knowledgecode

@knowledgecode knowledgecode commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • test: drop coverage.thresholds from vitest.config.ts (previously 100% lines/statements/functions, 95% branches).

Coverage is still collected and uploaded to Codecov by the coverage job; it's just informational now.

Test plan

  • npm run test:coverage completes successfully (exit 0) regardless of coverage percentage
  • npm run lint
  • npm run ts

External contributors should be able to open PRs without meeting a
coverage bar. The PR check (lint -> test) never ran coverage, but the
push-only coverage job enforced thresholds and could fail after merge.
Drop the thresholds so Codecov reporting is reference-only and never
fails CI.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (f864518) to head (ae6e8cd).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          77       77           
  Lines        1233     1233           
  Branches      357      357           
=======================================
  Hits         1218     1218           
  Partials       15       15           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knowledgecode
knowledgecode merged commit f2495b0 into master Sep 6, 2026
4 checks passed
@knowledgecode
knowledgecode deleted the develop branch September 6, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants