Repository navigation
Accept null-free immutable lists in box charts - #1033
Merged
Merged
Conversation
Histogram.sanityCheck had the same contains(null) call as BoxChart, which throws NullPointerException for List.of(...) data. Check elements directly instead, matching the box chart fix in this PR. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the data elements for null instead of calling
contains(null), which throws for Java immutable lists. Applies to series creation and replacement while preserving rejection of actual null elements. Tests cover add/replace/update;TestForIssue1032.getChart()provides the required standalone demo and was exercised headlessly.Validation:
mvn clean verify; mvn verify after formatting— 171 tests, no failures/errors, 0 skipped (JDK 11).The repository config skips
mvn fmt:check; the four changed Java files pass a direct check with the same google-java-format 1.23.0 used by its formatter plugin.Fixes #1032.