Skip to content

fix: honor negotiated group encryption and improve failure diagnostics - #21

Merged
kongesque merged 2 commits into
mainfrom
feat/core-cli-follow-up
Oct 17, 2026
Merged

kongesque merged 2 commits into
mainfrom
feat/core-cli-follow-up

Conversation

@kongesque

Copy link
Copy Markdown
Owner

Group text, mentions, and replies could fail with TalkException 82 because the CLI discarded the negotiated group encryption version and always sent a V2 envelope. Sends now select V1/V2 from the latest group-key response and label the envelope consistently. Unsupported versions fail before sending, and V2 encryption failures no longer fall back to mislabeled V1 chunks.

Adds safe numeric request diagnostics and an opt-in messages --diagnostics --json view of returned IDs before decryption. This branch also fixes chat search when a contact profile is unavailable. Protocol provenance, diagnostic contracts, and regression coverage are documented.

Validation:

  • Build and CLI help smoke check passed.
  • Main contributor race suite, goimports, go vet, and staticcheck passed.
  • Authorized live baseline, mention, and reply sends each succeeded once in the designated two-member test group. All three decrypted in history; mention target and reply relationship matched. No automatic mutation retries or group-key registration occurred.

The original issue's historical reply remains unexplained. Attachment and V2 flows have synthetic coverage; live verification covered negotiated V1 text, mention, and reply sends.

Closes #20.

@kongesque
kongesque merged commit aeb4515 into main Oct 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: group mention and reply sends report unknown outcome; delivered reply missing from history

1 participant