Repository navigation
fix: honor negotiated group encryption and improve failure diagnostics - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group text, mentions, and replies could fail with TalkException 82 because the CLI discarded the negotiated group encryption version and always sent a V2 envelope. Sends now select V1/V2 from the latest group-key response and label the envelope consistently. Unsupported versions fail before sending, and V2 encryption failures no longer fall back to mislabeled V1 chunks.
Adds safe numeric request diagnostics and an opt-in
messages --diagnostics --jsonview of returned IDs before decryption. This branch also fixes chat search when a contact profile is unavailable. Protocol provenance, diagnostic contracts, and regression coverage are documented.Validation:
The original issue's historical reply remains unexplained. Attachment and V2 flows have synthetic coverage; live verification covered negotiated V1 text, mention, and reply sends.
Closes #20.