Repository navigation
[DOCS]: Fix kpt fn sink documentation - #4836
Merged
Merged
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
requested review from
a team
and
a balanced review from Copilot
October 28, 2026 14:06
CsatariGergely
requested review from
kispaljr,
liamfallon and
mozesl-nokia
as code owners
October 28, 2026 14:06
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The generated CLI documentation still needs regeneration and committing, as kpt fn source --help continues to recommend the failing pipeline despite the website correction.
What changed in this PR
Corrects the kpt fn source documentation example to address #2526 by writing processed resources to a different directory instead of the source directory.
Changes:
- Changes the pipeline destination from
DIRtoOTHER_DIR. - Updates the accompanying comment to match the new destination.
| File | Description |
|---|---|
documentation/content/en/reference/cli/fn/source/_index.md |
Corrects the example pipeline and its explanatory comment. |
Review effort: Balanced
Catalin-Stratulat-Ericsson
approved these changes
Oct 28, 2026
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
approved but copilot comment is valid and should be incorporated
aravindtga
approved these changes
Oct 29, 2026
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
mozesl-nokia
approved these changes
Oct 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2526