Empty a set when ExceptWith is passed the set itself - #67
Merged
Merged
Conversation
ContiguousSet, OrderedSet and InsertionOrderSet removed each item of `other` while enumerating it. When `other` was the set itself, the ContiguousSet enumerator skipped every other element and the List-backed sets threw InvalidOperationException. Clear the set instead, matching HashSet<T>. Fixes #65 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Hhb8knddbu4LRSs2uu9jR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65
Problem
ExceptWithinContiguousSet,OrderedSetandInsertionOrderSetcalledRemoveon each item ofotherwhile enumerating it. Whenotherwas the set itself:ContiguousSetskipped every other element, so{1,2,3,4}became{2,4}.OrderedSetandInsertionOrderSetthrewInvalidOperationException.HashSet<T>clears the set in this case.Fix
After the null check, each
ExceptWithnow checksReferenceEquals(other, this). If it is true, it callsClear()and returns. The other set operations already copyotherinto a temporary set first, so they did not need changing.Tests
I added
ExceptWith_Self_EmptiesSettoContiguousSetTests,OrderedSetTestsandInsertionOrderSetTests.With the fix reverted, all 3 fail. With it, the full suite passes (376/376).
This PR is independent of #63 and #64; all three branch from
main.🤖 Generated with Claude Code
https://claude.ai/code/session_012Hhb8knddbu4LRSs2uu9jR
Generated by Claude Code