Release cleared elements in RingBuffer.Clear - #74
Merged
matt-edmondson merged 1 commit intoSep 26, 2026
Merged
Conversation
Clear only reset the indices, so every reference-type element that was logically removed stayed reachable from the backing array until a later PushBack overwrote its slot. Clear the array first when T holds references, as the Contiguous containers already do. Fixes #72 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXTjHR3MfJpmxt8LEwNkjm
|
matt-edmondson
deleted the
claude/containers-72-ringbuffer-clear-references
branch
September 26, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
RingBuffer<T>.Clear()only resetBackIndex,FrontIndexandCount. The backing array kept every reference-type element that had been removed, so up to N objects stayed alive until a laterPushBackoverwrote their slots. If the buffer was never refilled, that never happened.Clear()now clears the backing array before it resets the indices, but only whenTholds references. On .NET 5+ that check isRuntimeHelpers.IsReferenceOrContainsReferences<T>(), and on netstandard it is!typeof(T).IsValueType.ContiguousCollectionalready does the same thing.Tests
Clear_ReleasesReferencesToClearedElements. It fills a buffer with objects that nothing else references, callsClear(), forces a GC, and asserts that everyWeakReferenceis dead.Expected condition to be false). With the fix it passes.Containers.Testsuite passes (390/390), and the Release build has no warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01YXTjHR3MfJpmxt8LEwNkjm
Generated by Claude Code