Accept Nullable element types in the ordered containers without a comparer - #77
Merged
Merged
Conversation
…a comparer [patch] The no-comparer constructors of OrderedSet, OrderedCollection and OrderedMap required T itself to implement IComparable<T> or IComparable. Nullable<U> implements neither, so int?, DateTime? and the like were rejected even though Comparer<T>.Default orders them, null first. Move the check into one Comparability.HasDefaultOrdering<T>() helper that falls back to the nullable's underlying type, and use it in every constructor of the three containers. Fixes #71 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXTjHR3MfJpmxt8LEwNkjm
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #71
When no comparer is passed, the constructors of
OrderedSet<T>,OrderedCollection<T>andOrderedMap<TKey,TValue>required the type itself to implementIComparable<T>orIComparable.Nullable<U>implements neither, sonew OrderedSet<int?>()threwArgumentException, even thoughComparer<int?>.Defaultorders nullable values with null first.Change
Comparability.HasDefaultOrdering<T>(). It keeps the old check, and when the type isNullable<U>it falls back to checkingU.OrderedMap's primary-constructor field initializer.KeyValuePair<int,int>?, is still rejected.OrderedMapkeeps itswhere TKey : notnullconstraint, the same oneDictionaryhas.OrderedMap<int?, …>therefore still produces compiler warning CS8714, and null keys are still rejected at run time. The difference is that construction and ordering no longer fail.Tests
int?instances through the parameterless, capacity and collection constructors and check that the order matchesComparer<int?>.Default, with null first for the set and the collection.KeyValuePair<int,int>?case still throws.Containers.Testsuite passes (395/395), and the Release build has no warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01YXTjHR3MfJpmxt8LEwNkjm
Generated by Claude Code