Skip to content

Build go-licenses with the same toolchain as the main module #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiffanny29631 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build go-licenses with the same toolchain as the main module #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,16 @@ DOTFILE_IMAGE = $(subst /,_,$(IMAGE))-$(OS_ARCH_TAG)

LICENSES = .licenses

# go-licenses identifies stdlib packages by its compiled-in GOROOT, so it must
# be built with the same toolchain that the main module selects when it runs
# `go list`. Otherwise (e.g. with GOTOOLCHAIN=auto and an older host Go) the
# tools module and the main module can resolve to different toolchains, and
# every stdlib package is reported as "does not have module info".
$(LICENSES):
pushd tools >/dev/null; \
export GOOS=$(shell go env GOHOSTOS); \
export GOARCH=$(shell go env GOHOSTARCH); \
export GOTOOLCHAIN=$(shell go env GOVERSION); \
go build -o ../bin/tools/ github.com/google/go-licenses/v2; \
popd >/dev/null
rm -rf $(LICENSES)
Expand Down