Repository navigation
chore: drop dead legacy genesis code and unused TLSNotary URL settings - #1024
Conversation
The legacy genesis routine in subOperations.ts has no callers since the chain moved to chainGenesis.ts, and it calls a GCR balance setter that was removed with the deprecated GCR entities. Its fail-loud test only exercised that dead path through mocks; both go. The TLSNotary config read TLSNOTARY_EXPOSED_URL and TLSNOTARY_PROXY_URL through env keys that were never declared, so both settings were always empty. Declare the keys and give them empty defaults. The fork config test still expected the placeholder treasury after the default gained a real one; it now reads the default instead.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
… treasury default off the placeholder
What
subOperations.tshas no callers since genesis moved tochainGenesis.ts, and it callsGCR.setGCRNativeBalance, which was removed with the deprecated GCR entities. Its fail-loud test only exercised that dead path through mocks; both are removed.TLSNOTARY_EXPOSED_URLandTLSNOTARY_PROXY_URLwere read through undeclared env keys (always empty) and nothing used them; the public notary and proxy URLs come from the node exposed URL and the/tlsn/<port>/route. Removed from config, types and.env.example.Tests
loadForkConfig.test.ts31/31 (was 30/31 onstabilisation).tsc --noEmit: 90 → 81.