Skip to content

chore: drop dead legacy genesis code and unused TLSNotary URL settings - #1024

Merged
Shitikyan merged 2 commits into
stabilisationfrom
chore/dead-code-tlsn-config
Oct 1, 2026
Merged

Shitikyan merged 2 commits into
stabilisationfrom
chore/dead-code-tlsn-config

Conversation

@Shitikyan

@Shitikyan Shitikyan commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Dead legacy genesis code removed. subOperations.ts has no callers since genesis moved to chainGenesis.ts, and it calls GCR.setGCRNativeBalance, which was removed with the deprecated GCR entities. Its fail-loud test only exercised that dead path through mocks; both are removed.
  • Unused TLSNotary URL settings removed. TLSNOTARY_EXPOSED_URL and TLSNOTARY_PROXY_URL were read through undeclared env keys (always empty) and nothing used them; the public notary and proxy URLs come from the node exposed URL and the /tlsn/<port>/ route. Removed from config, types and .env.example.
  • Stale fork config test fixed. It expected the placeholder treasury after the default gained a real address in C1-apply binding under gasFeeSeparation + activate gasFee @0 (audit 184) #938; it now reads the default and asserts it is not the placeholder.

Tests

  • All fork and TLSNotary test files pass (one file per command); loadForkConfig.test.ts 31/31 (was 30/31 on stabilisation).
  • tsc --noEmit: 90 → 81.

The legacy genesis routine in subOperations.ts has no callers since the
chain moved to chainGenesis.ts, and it calls a GCR balance setter that was
removed with the deprecated GCR entities. Its fail-loud test only exercised
that dead path through mocks; both go.

The TLSNotary config read TLSNOTARY_EXPOSED_URL and TLSNOTARY_PROXY_URL
through env keys that were never declared, so both settings were always
empty. Declare the keys and give them empty defaults.

The fork config test still expected the placeholder treasury after the
default gained a real one; it now reads the default instead.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ac72139e-aa1c-4e06-8f59-45e2e8521308

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Removes legacy genesis code and TLSNotary configuration options.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR removes an unused legacy genesis routine and its test, removes TLSNotary URL settings whose semantics are not defined, and strengthens the fork-config treasury test.

  • The related SDK uses its own TLSNotary configuration type and does not consume the removed node configuration fields.

Reviews (2) · Last reviewed commit: "chore(config): drop the TLSNotary URL se..."

Comment thread src/config/envKeys.ts Outdated
Comment thread testing/forks/loadForkConfig.test.ts
@Shitikyan Shitikyan changed the title chore: drop dead legacy genesis code and wire the TLSNotary URL settings chore: drop dead legacy genesis code and unused TLSNotary URL settings Oct 1, 2026
@Shitikyan
Shitikyan merged commit 34b52c1 into stabilisation Oct 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant