Skip to content

chore(deps): move the node to demosdk 4.0.17 - #1025

Merged
Shitikyan merged 1 commit into
stabilisationfrom
chore/sdk-4.0.17
Oct 5, 2026
Merged

Shitikyan merged 1 commit into
stabilisationfrom
chore/sdk-4.0.17

Conversation

@Shitikyan

Copy link
Copy Markdown
Contributor

What

  • @kynesyslabs/demosdk 4.0.12 → 4.0.17 (dependency and override), bun.lock regenerated (bun install --frozen-lockfile is clean).
  • 4.0.17 ships the atomicWork edit types, so the Atomic Work variant test type-checks again.
  • The SDK now types Transaction.attrs (reference_block required). The node's Transaction takes that type plus the message it records on failed transactions; the genesis transaction keeps the empty attrs it has always been stored with (type-only cast, no stored or hashed value changes).

Tests

  • 4-node end-to-end (testing/atomic-work/e2e.sh): 41/41, with the nodes themselves on SDK 4.0.17 (base image layered with the 4.0.17 package; image check showed 4.0.9 before) and the client on SDK main.
  • All 86 bun test files run one per command: the only failures are the 10 pre-existing ones on stabilisation (no local Postgres for zk, jest.requireMock/requireActual under bun, stale senderKey export, peer manager init order, mock leakage in rateLimiter); none involve the SDK change. txSignatureDomain passes 8/8 under jest.
  • bun run type-check (the CI build check) passes; tsc --noEmit 81 → 67 errors.

4.0.17 ships the atomicWork edit types the node's own Work code and tests
already use, so the Atomic Work variant test type-checks again.

The SDK now types a transaction's attrs, with reference_block required.
The node's Transaction keeps its stored shape: it takes the SDK's attrs
type plus the failure message the node records, and the genesis
transaction keeps the empty attrs it has always been stored with.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 60e4862e-cc16-4a57-9737-3767c826e40a
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[High risk] Upgrades the blockchain SDK dependency.

The PR appears safe to merge, with a non-blocking type-safety concern around genesis attrs.

Fix All in Claude CodeFindings

  1. P2 Genesis attrs hide missing field ▶
Fix with agent prompt
### Issue 1
src/libs/blockchain/chainGenesis.ts:60
This assertion treats the genesis transaction’s empty `attrs` as the SDK’s [transaction attrs type](https://github.com/kynesyslabs/sdks/blob/HEAD/src/types/blockchain/Transaction.ts), which requires `reference_block`. A caller relying on that type can read the field without a guard but receive `undefined` for genesis. Modeling genesis as an explicit exception would keep that difference visible to future callers.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary

The PR upgrades demosdk from 4.0.12 to 4.0.17 and regenerates the Bun lockfile.

  • It aligns the node’s transaction attrs type with the SDK while retaining the existing empty genesis attrs value.

Reviews (1) · Last reviewed commit: "chore(deps): move the node to demosdk 4...."

Comment thread src/libs/blockchain/chainGenesis.ts
@Shitikyan
Shitikyan merged commit ac29c00 into stabilisation Oct 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant