Repository navigation
chore(deps): move the node to demosdk 4.0.17 - #1025
Conversation
4.0.17 ships the atomicWork edit types the node's own Work code and tests already use, so the Atomic Work variant test type-checks again. The SDK now types a transaction's attrs, with reference_block required. The node's Transaction keeps its stored shape: it takes the SDK's attrs type plus the failure message the node records, and the genesis transaction keeps the empty attrs it has always been stored with.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
What
@kynesyslabs/demosdk4.0.12 → 4.0.17 (dependency and override),bun.lockregenerated (bun install --frozen-lockfileis clean).atomicWorkedit types, so the Atomic Work variant test type-checks again.Transaction.attrs(reference_blockrequired). The node'sTransactiontakes that type plus themessageit records on failed transactions; the genesis transaction keeps the emptyattrsit has always been stored with (type-only cast, no stored or hashed value changes).Tests
testing/atomic-work/e2e.sh): 41/41, with the nodes themselves on SDK 4.0.17 (base image layered with the 4.0.17 package; image check showed 4.0.9 before) and the client on SDK main.stabilisation(no local Postgres for zk,jest.requireMock/requireActualunder bun, stalesenderKeyexport, peer manager init order, mock leakage inrateLimiter); none involve the SDK change.txSignatureDomainpasses 8/8 under jest.bun run type-check(the CI build check) passes;tsc --noEmit81 → 67 errors.