Skip to content

ci: fix the duplicated trigger key so the workflow runs again - #1026

Merged
Shitikyan merged 1 commit into
stabilisationfrom
fix/ci-workflow
Oct 5, 2026
Merged

Shitikyan merged 1 commit into
stabilisationfrom
fix/ci-workflow

Conversation

@Shitikyan

Copy link
Copy Markdown
Contributor

What

.github/workflows/ci.yml has had two on: keys since April (c94c695). GitHub rejects it as an invalid workflow, so every run since then fails instantly ("This run likely failed because of a workflow file issue") and neither lint nor the build check has run on any push or PR.

  • Remove the duplicate key.
  • Keep the Type Check job (bun install --frozen-lockfile + bun run type-check): it passes on stabilisation today.
  • Leave Lint out for now: bun run lint reports 251 errors / 823 warnings on stabilisation, so enabling it would fail every PR. Clearing that backlog (161 errors are auto-fixable) is a separate change.

Tests

  • YAML parses with a single trigger block; this PR's own run exercises the fixed workflow.
  • Locally on stabilisation: bun install --frozen-lockfile clean, bun run type-check exit 0, bun run lint exit 1 (251 errors).

ci.yml has carried two 'on:' keys since April, which GitHub rejects as an invalid workflow, so neither lint nor the build check ran on any push or PR. Keep the build check (passes on stabilisation) and leave lint out until its 251-error backlog is cleared, so the fix does not turn every PR red.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b7e93af9-ad38-42b5-bccc-9699bb5a7836
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Critical risk] Workflow trigger and job configuration changed.

The PR appears safe to merge.

Summary

The PR removes the duplicate workflow trigger so CI can run, retains the Type Check job, and leaves lint disabled while its existing errors are addressed separately.

Reviews (1) · Last reviewed commit: "ci: fix the duplicated trigger key so th..."

@Shitikyan
Shitikyan merged commit 1260e06 into stabilisation Oct 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant