Repository navigation
fix(tooling): follow the project's Node runtime - #708
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a873c0e to
556f06d
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 556f06df79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
After dependency preparation, execute the target checkout's own lastcode:ci command with the requested mode. This preserves its Node pin when a shared Action targets an older checkout whose runtime guard still requires Node 24. Cover older target runtime selection for Quick and Full CI, nested Node processes, preparation failure and CI exit propagation. Carry-Group: incubator Carry-Fix: #708 (comment) Carry-Observation: The shared Action declaration is reconciled by Incubator; its runtime-selection repair and focused fixtures must replay together after that declaration.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5981f9a to
ffa4028
Compare
Move package commands, installed launchers, CI, and setup examples to Node 26.12.1. Package builds resolve the selected tag's own CI runtime so existing installables remain buildable. Keep the pilot rejection assertion and isolate the merge-lock hook fixture from global Git settings. Carry-Group: build-ci Carry-Fix: #665 Carry-Upstream: https://redirect.github.com/pingdotgg/t3code/pull/23165 Carry-Observation: Runtime setup follows upstream Node alignment commit ed9b7ca; historical package tags retain their own CI runtime.
Keep Action reconciliation fixtures aligned with the downstream runtime declarations. Carry-Group: resumable-actions Carry-Fix: #665
Accept root engines.node exactly alongside temporary Node ^24.13.1 support, and align setup and Action declarations with Node 26.12.1. Carry-Group: incubator Carry-Fix: #665 Carry-Observation: These runtime and setup edits depend on definitions currently introduced or reconciled by the Incubator group, so they must replay after it. Independent packaging and CI edits remain in Build & CI, and Action reconciliation fixtures remain in Resumable Actions.
After dependency preparation, execute the target checkout's own lastcode:ci command with the requested mode. This preserves its Node pin when a shared Action targets an older checkout whose runtime guard still requires Node 24. Cover older target runtime selection for Quick and Full CI, nested Node processes, preparation failure and CI exit propagation. Carry-Group: incubator Carry-Fix: #708 (comment) Carry-Observation: The shared Action declaration is reconciled by Incubator; its runtime-selection repair and focused fixtures must replay together after that declaration.
39a2c19 to
be506d9
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A later metadata-only CI check suite leaves GitHub expecting CI Gate despite successful exact-head CI and a successful gate rerun. Refresh the source check suite with an unchanged tree. Carry-Group: build-ci Carry-Observation: This empty commit refreshes GitHub required checks; it changes no source behavior.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
LastCode's merge and local CI scripts rejected Node 26.12.1 even though root
engines.nodealready requires it. This also made the merge-lifecycle tests fail unless Node 24 came first on PATH. Fixes #665.The runtime guard now accepts the exact version in root
engines.node, with temporary support for^24.13.1while saved Project Actions migrate. Downstream package commands, Action declarations, installed launchers, setup examples, and pilot CI select Node 26.12.1; package tests no longer override the project runtime with Node 24. Existing Settings are unchanged. After preparation, the shared CI Action executes the target checkout's own CI command, preserving that checkout's runtime pin for both Quick and Full CI. Local package builds also select the target tag's CI runtime so older installable tags remain buildable.Upstream's Node alignment came from https://redirect.github.com/pingdotgg/t3code/pull/23165 at
ed9b7ca9c53843ea1e6b466bf7d52928d10e7db0.Validation:
Local review: 1 round with GPT-6.1 Sol (high) found the older-tag build regression, now fixed. Pre-push reviews with GPT-6.1 Terra (xhigh) approved the full diff, the Action runtime fix, and the final rebase onto the current checkpoint. Claude's writing pass was skipped because its quota was exhausted.
Implemented with Claude Opus 5.5 in the Claude Code harness and GPT-6.1 Sol in the Codex harness.