feat: Split summary counters by overrideAffected and suppress individual events for marked evaluations - #365
Draft
kinyoklion wants to merge 1 commit into
Conversation
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-override-layer
branch
from
September 28, 2026 20:39
49ba8e2 to
d9e0211
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-events-internal
branch
from
September 28, 2026 20:39
9387b50 to
3aacd97
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-override-layer
branch
from
October 1, 2026 23:43
d9e0211 to
092ed5c
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-events-internal
branch
from
October 1, 2026 23:43
3aacd97 to
471a60c
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-override-layer
branch
from
October 3, 2026 01:34
092ed5c to
716b005
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-events-internal
branch
from
October 3, 2026 01:34
471a60c to
a750428
Compare
Member
Author
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a750428. Configure here.
…ual events for marked evaluations EventTypes.EvaluationEvent gains an OverrideAffected field. A marked evaluation produces no individual feature event and no debug event, whatever the flag requests, and is counted under a separate summary counter whose key includes the marker. The summary output writes "overrideAffected": true on such a counter and omits the property otherwise, as defined by the OVERRIDE specification.
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-override-layer
branch
from
October 3, 2026 01:52
716b005 to
041e7a5
Compare
kinyoklion
force-pushed
the
rlamb/overrides-dotnet-events-internal
branch
from
October 3, 2026 01:52
a750428 to
c9ce308
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the analytics event processing in LaunchDarkly.InternalSdk for override-affected evaluations, as defined by the OVERRIDE specification.
EventTypes.EvaluationEventgains anOverrideAffectedfield. When it is set, the event processor produces no individual feature event and no debug event for the evaluation, whatever the flag'sTrackEventsandDebugEventsUntilDaterequest. The evaluation is still counted in summary events, and the marker becomes part of the summary counter key, so override-affected and other evaluations of the same flag key, variation, and version accumulate into separate counters instead of being collapsed together. The summary event output writes"overrideAffected": trueon a marked counter and omits the property otherwise, following the existingunknownmarker. The summarizer interface carries the marker through both the aggregated and the per-context summarizers.Nothing sets the field yet; the server SDK does so in the next change. Every existing event path is unchanged when the field is false, which the existing event processor and output tests confirm. New tests cover the suppression of feature and debug events, the suppression of a marked prerequisite record, the separate counters, and the counter serialization.
This PR is based on the branch of the override layer change so that the whole flag overrides series applies as one linear sequence; it uses nothing from that branch.
SDK-3248
Note
Overview
Adds
OverrideAffectedonEvaluationEventso override-driven evaluations follow OVERRIDE analytics rules: they still roll into summary counters but never emit feature or debug events, even when tracking or debug mode is on.Summary aggregation now keys counters by version, variation, and
overrideAffected, so marked and unmarked evaluations of the same flag do not merge. Serialized summary counters includeoverrideAffected: true when set (omitted otherwise).IEventSummarizer.SummarizeEventand the aggregated/per-context summarizers pass the flag through;EventProcessorInternalapplies the suppression logic. No production code sets the field in this PR (defaults false); tests cover suppression, separate counters, and JSON output.Reviewed by Cursor Bugbot for commit a750428. Bugbot is set up for automated code reviews on this repo. Configure here.