Repository navigation
fix: Keep polling after an unexpected HTTP error response - #350
Draft
jsonbailey wants to merge 1 commit into
Draft
jsonbailey wants to merge 1 commit into
jsonbailey wants to merge 1 commit into
Conversation
jsonbailey
added this pull request to stack #353
October 16, 2026 06:33
jsonbailey
commented
Oct 16, 2026
| /// effect only when asserts are enabled, as in debug builds and tests. A | ||
| /// release build always applies the minimum. | ||
| @visibleForTesting | ||
| static bool ignorePollingMinimum = false; |
Author
There was a problem hiding this comment.
Test-only hook, used only when asserts are on. iOS has the same idea (ignorePollingMinimum, internal, through @testable), and Android has ComponentsImpl...pollIntervalMillisNoMinimum. Neither test service applies pollIntervalMs yet, so sdk-test-harness #501 must not merge until they do.
Author
There was a problem hiding this comment.
We may not want to include this in the final iteration, but we can just keep this locally for quick testing, but long term to the long running tests approach.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #350. Docs and tests only.
identify()andstart()keep their current results: a data source failure givesIdentifyErrororfalse. With these retry changes, the SDK then keeps retrying in the background, and flags and status update when data arrives.IdentifyError,identify(),start()andinitializeddocs now say this, and point to flag change and data source status listeners.