Repository navigation
docs: Explain that the SDK keeps retrying after identify or start reports a failure - #351
Draft
jsonbailey wants to merge 1 commit into
Draft
jsonbailey wants to merge 1 commit into
jsonbailey wants to merge 1 commit into
Conversation
jsonbailey
added this pull request to stack #353
October 16, 2026 06:33
jsonbailey
commented
Oct 16, 2026
| /// | ||
| /// [IdentifyError] this means that the identify has permanently failed. For | ||
| /// instance the SDK key is no longer valid. | ||
| /// [IdentifyError] means that the SDK encountered an error before it loaded |
Author
There was a problem hiding this comment.
Cross-SDK note, for team discussion: on a data source failure, Android completes identify as a success without setting initialized (ConnectivityManager start callback onError) and keeps retrying. iOS waits for data, and identifies queued behind a waiting one stay blocked. Flutter keeps main's result (IdentifyError / start() false) and now keeps retrying in the background. We tried "wait for data" here, but it caused several races in the identify queue, so we chose the Android model.
Author
There was a problem hiding this comment.
Lets make sure client SDKs are willing to terminate a not yet finished identify / data fetch if another identify comes in, this behavior may be made worse by RETRY conformance.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #351. The FDv1 streaming data source no longer stops for good after an HTTP error such as a 401.
autoReconnect: false, closes it on any failure, and reconnects after theRetryStatedelay: 1 second up to 30 seconds normally, and 5 minutes up to 1 hour after an unexpected failure. The backoff resets after 60 seconds of healthy streaming.interrupted, as Android FDv2 does, and logs the failure kind.retry-conformance-fdv1-streaming.common_clientneeds the releasedlaunchdarkly_event_source_clientandlaunchdarkly_dart_commonversions before this merges. The pin bumps follow those releases.