Repository navigation
fix: Include an error type in provider error events - #73
Open
kinyoklion wants to merge 1 commit into
Open
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
OFP requirement 5.1.5 (sdk-specs
OFP-openfeature-provider-behavior):PROVIDER_ERRORevents SHOULD populate the event details' error code.Describe the solution you've provided
StatusProvider.EmitProviderEventsetsProviderEventPayload.ErrorType = ErrorType.GeneralforProviderEventTypes.ProviderErrorevents (emitted when the LaunchDarkly data source isOff). AddedProviderTests.ItIncludesAnErrorTypeInErrorEvents.Describe alternatives you've considered
A more specific type (e.g.
ProviderFatalfor 401/403) was not used; OFP does not define a mapping, and the Python provider already usesGENERALfor the same transition.Additional context
Validated locally with
dotnet teston net8.0 (69 passed).Link to Devin session: https://app.devin.ai/sessions/929f5530882d40bc95e55391e97536d5
Open in Devin Desktop: https://app.devin.ai/desktop/session/929f5530882d40bc95e55391e97536d5?variant=devin
Requested by: @kinyoklion
SDK-3255
Note
Overview
Aligns provider status error events with OpenFeature provider behavior (OFP 5.1.5) by populating the event’s error code when the provider reports an error.
StatusProvider.EmitProviderEventnow setsProviderEventPayload.ErrorTypetoErrorType.Generalwhenever the event type isProviderError(e.g. when status moves toError/Fatalafter the data source isOff). A new test drives a post-init data-sourceOfftransition and asserts the emitted event isProviderErrorwithErrorType.General.Reviewed by Cursor Bugbot for commit 7a95e73. Bugbot is set up for automated code reviews on this repo. Configure here.