Repository navigation
docs: Note rejected SDK key retry in the initialization matrix row - #77
Open
kinyoklion wants to merge 2 commits into
Open
kinyoklion wants to merge 2 commits into
kinyoklion wants to merge 2 commits into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…me-rejected-key-init Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com> # Conflicts: # README.md
kinyoklion
marked this pull request as ready for review
October 16, 2026 21:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaunchDarkly .NET SDK 8.17.0 made a rejected SDK key (401/403 and other 4xx) retryable, so the data source no longer reaches
Offfor it. The README matrix still saidInitializeAsyncwaits until the client becomes ready "or fails permanently", which is no longer true for a rejected key.InitializeAsynccan wait indefinitely. It links the provider-side tracking PR #71 (start wait).StartWaitTimeis 10 seconds (ConfigurationBuilder.DefaultStartWaitTime). The README said 5.Details
Requirements
Related issues
#71
Describe the solution you've provided
The provider references
LaunchDarkly.ServerSdk[8.1.0,9.0), so new installs resolve to 8.17.x and get the retry behavior. 8.17.0 release notes: "DataSourceState.Offno longer indicates a rejected SDK key.Offis now reached only by explicit shutdown."mainwas merged in after #72 (cancellation token) landed. The row now keeps #72's cancellation wording and no longer links #72 as a gap.Additional context
#71 also edits the Initialization row. Whichever merges second will need a small README conflict fix.
Found in the weekly OpenFeature provider audit. Docs-only change.
Link to Devin session: https://app.devin.ai/sessions/2a67f9d291bc4417bb40f632c191b44f
Open in Devin Desktop: https://app.devin.ai/desktop/session/2a67f9d291bc4417bb40f632c191b44f?variant=devin
Requested by: @kinyoklion
Note
Overview⚠️ ) and revises how
Updates the README Initialization feature matrix row to partial (
InitializeAsyncbehaves with LaunchDarkly .NET SDK 8.17.0+: a rejected SDK key is retried instead of failing permanently, so without aSetProviderAsynccancellation token initialization can wait indefinitely. The row now says init waits until ready or shutdown (not permanent failure) and links provider follow-up #71.In Asynchronous Initialization, the documented default constructor blocking wait is corrected from 5 to 10 seconds to match
ConfigurationBuilder.DefaultStartWaitTime.Reviewed by Cursor Bugbot for commit 7920750. Bugbot is set up for automated code reviews on this repo. Configure here.